Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more error handlers to ExpressReceiver #1406

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add more error handlers to ExpressReceiver #1406

merged 1 commit into from
Mar 30, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 30, 2022

Summary

As mentioned at #1402, ExpressReceiver does not have the additional error handlers. This pull request adds those to the receiver.

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label Mar 30, 2022
@seratch seratch added this to the 3.11.0 milestone Mar 30, 2022
@seratch seratch requested review from mwbrooks and filmaj March 30, 2022 12:43
@seratch seratch self-assigned this Mar 30, 2022
@seratch seratch mentioned this pull request Mar 30, 2022
Closed
10 tasks
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #1406 (8d35b42) into main (c071816) will increase coverage by 0.16%.
The diff coverage is 40.90%.

❗ Current head 8d35b42 differs from pull request most recent head 43829ff. Consider uploading reports for the commit 43829ff to get more accurate results

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
+ Coverage   79.61%   79.78%   +0.16%     
==========================================
  Files          17       17              
  Lines        1452     1459       +7     
  Branches      428      431       +3     
==========================================
+ Hits         1156     1164       +8     
+ Misses        199      198       -1     
  Partials       97       97
Impacted Files Coverage Δ
src/receivers/HTTPModuleFunctions.ts 78.72% <0.00%> (-0.85%) ⬇️
src/receivers/ExpressReceiver.ts 71.35% <42.85%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c071816...43829ff. Read the comment docs.

filmaj
filmaj approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, amazing that the total project coverage went up even though this PR has no tests 😂

src/receivers/ExpressReceiver.ts Show resolved Hide resolved
@seratch
Copy link
Member Author

seratch commented Mar 30, 2022

@filmaj

amazing that the total project coverage went up even though this PR has no tests 😂

haha, I was wondering about it, too :lol:

@seratch seratch merged commit a50879a into slackapi:main Mar 30, 2022
@seratch seratch deleted the express-receiver-customization branch March 30, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seratch @filmaj